Obscure App builder crash

[alia]

Hi,

Don't ask how I found this out because it was a really long process . Just put this code in a page's prg and click the button and the app builder crashes (the database must exist).

The problem appears to be the '&sql' executing inside a try block, if this happens and then an error is generated afterwards, the crash occurs.
Changing various elements of the code causes the problem not to occur, this was the only combination where I could get it to happen reliably.

////////////////////////////////////////////////////////////////
// Event delegate for 'click' event
proc page1_section2_field2_click()

	dbName = "mydb"
	if ExecuteCommand1('open database &dbName')		
		
		private tab[]			
		tab._name = "a"
		//This will raise an error
		if tab.name = "a"
		endif		
		
	endif	
	
endproc


function ExecuteCommand1(sql)

	try		
		&sql
		return .T.
	catch to e
		return .F.		
	endtry
	
endfunc

[alia]

Hi,

This has turned into quite a big problem for me because I have quite a long routine that loops through lots of data, if my code hits any error then the ide crashes and I am certain it is related to the issue above. There is too much data for me to step through manually and if I just let it run then the ide crashes and I don't know what code is running at the time of the crash.

[josipradnik]

Before going further, is it typo?

tab._name = "a"
if tab.name

I mean: tab.name and tab._name

[yvonne.milne]

Hi Alia,

Put the return statements outside the try/endtry block:

function ExecuteCommand1(sql)

        try
                &sql
                // ? "Tried"
                lreturn  = .T.
        catch to e
        	// ? "Caught"
                lreturn  = .F.
        endtry
		return lreturn
endfunc

Can you also Submit a Ticket for this.

Thanks,

Yvonne

[josipradnik]

Also, instead of:

dbName = "southwind"
if ExecuteCommand1('open database &dbName')

I would try

dbName = "southwind"
mycommand='open database '+dbName
?mycommand // so you can inspect 
if ExecuteCommand1(mycommand)

[alia]

No, I purposely left that typo in so an error will be raised that will cause the ide crash.

[alia]

This works Yvonne, thanks I will log a ticket

Hi Alia,

Put the return statements outside the try/endtry block:

function ExecuteCommand1(sql)

        try
                &sql
                // ? "Tried"
                lreturn  = .T.
        catch to e
        	// ? "Caught"
                lreturn  = .F.
        endtry
		return lreturn
endfunc

Can you also Submit a Ticket for this.

Thanks,

Yvonne

[HankFay]

FWIW: in VFP a RETURN is also not allowed inside a TRY block or a CATCH block. I think it is in the FINALLY block. Basically, if you are going somewhere else, you have to get out of the try/catch first.

Hank

[barrymavin]

The use of RETURN in a TRY/CATCH block is not legal in Lianja/VFP.

I have corrected this behavior in v2.1Beta2 and reported an error when it is used incorrectly.